Conversation
vprajeetreddy-404
requested changes
May 20, 2023
Collaborator
vprajeetreddy-404
left a comment
vprajeetreddy-404
left a comment
There was a problem hiding this comment.
Looks good! A few nitpicks to resolve.
README.md
Outdated
| # GoogleSignInVerification No newline at end of file | ||
| # Google Sign-In Verification | ||
|
|
||
| This repository contains code for an API endpoint that verifies Google Sign-In tokens and retrieves user information. It can be integrated with a SwiftUI front-end application. |
Collaborator
There was a problem hiding this comment.
Since it is deployed as a Lambda function, we can use the term "Lambda function" instead of "API endpoint".
Users.js
Outdated
| @@ -0,0 +1,96 @@ | |||
| const AWS = require('aws-sdk'); | |||
| const dynamodb = new AWS.DynamoDB.DocumentClient(); | |||
| const DYNAMODB_TABLE_NAME = "trips"; | |||
Collaborator
There was a problem hiding this comment.
The table name can be provided in .env as well
| }; | ||
| await dynamodb.put(putParams).promise(); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
remove space for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
A Lambda function that verifies Google Sign-In tokens and retrieves user information. It can be integrated with a SwiftUI front-end application.
Checklist
Instructions to review
Please review the code